-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to MSVC support for ci branch. #72
Conversation
This is necessary for some platforms, because they write a different amount of trailing zeroes for "%a" in the `printf` family.
This fixes compiler warnings on MacOS.
This is a bugfix for all platforms.
This reverts commit cd8f29b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission. I added 3 comments with questions.
To move this PR forward, could there be a rebase onto our main branch to eliminate conflicts when this is merged and then a bit of git rebase magic to combine/fixup WIP/testing commits? |
@Rossmaxx I am still working with the liblo team to setup a new release. In the mean time, can you please fix at least the issues which are still open? @fundamental That is what we usually do at the end. Right now, I do not want to touch it because it is already broken and I do not want to add more uncertainty to this PR. When the PR works, it should be the right time for a rebase. |
It would be of little use as this pr is not needed for master in any way and this only affects the ci branch. Merging ci with master after merging my pr is the best way imo. If you are talking about squashing the commits, i would like to but don't know much about that. I remember messing up a rebase one time and lost all my commits. |
Thanks @Rossmaxx . I will merge this. |
Oh, sorry, I cannot merge. Can you please solve the conflicts? |
There's none for ci branch. You might be trying to merge master. Btw did we get a new liblo release? |
Ah right, I could create a merge commit, only rebase was not possible. For liblo, we were working on a new release until today. There might be a release in this month, possibly. |
Notify me when it's done so that i can open a pr to add liblo's new version to vcpkg. |
I have been helping @JohannesLorenz with the ci branch for some time and have some fixes now. Here they are.
Note : To build on msvc properly, we should wait till liblo gets an updated release (or the workaround I used, which is to use
--head
while installing liblo on vcpkg. Though this step needs some debugging).