Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Focus Service, Translation Service]: Tests and refactoring #348

Merged
merged 5 commits into from
Apr 10, 2024
Merged

[Focus Service, Translation Service]: Tests and refactoring #348

merged 5 commits into from
Apr 10, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Apr 10, 2024 •
edited
Loading

Jira ticket: https://funidata.atlassian.net/browse/DS-257

  • Unit tests for Focus Service
  • Minor refactoring in components using Focus Service
  • Removed LanguageBadgeGroupService and moved its functionality to TranslationService
  • Adjusted Fieldset's focus element with initial focus

@videoeero videoeero added the chore Maintenance and refactoring related issue label Apr 10, 2024
@videoeero videoeero changed the title [Focus Service]: Tests and minor usage refactoring [Focus Service, Translation Service]: Tests and refactoring Apr 10, 2024
@github-actions github-actions bot temporarily deployed to docs-DS-257-focus-translation-service-check April 10, 2024 11:29 Inactive
@RiinaKuu RiinaKuu merged commit d4ca56c into main Apr 10, 2024
12 checks passed
@RiinaKuu RiinaKuu deleted the DS-257-focus-translation-service-check branch April 10, 2024 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Maintenance and refactoring related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@videoeero @RiinaKuu