[Footer, Fieldset, FormSubmitDirective]: Footer logo refactor and fix few bugs #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
videoeero
commented
Apr 16, 2024
•
videoeero
commented
- Refactored Funidata logo svg used in Footer
- Adjusted Footer's a11y attributes
- Fixed a bug where Error Summary did not focus to Fieldset elements
- Fixed a bug where FormSubmitDirective fired when pressing Enter key inside any Form elements
- Removed old unused Cypress tests
github-actions
bot
temporarily deployed
to
docs-footer-logo-svg-refactor
github-actions
bot
requested a deployment
to
docs-footer-logo-svg-refactor
github-actions
bot
temporarily deployed
to
docs-footer-logo-svg-refactor
github-actions
bot
temporarily deployed
to
docs-footer-logo-svg-refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.