[Grid, FormSubmit]: Adjustments for Safari #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
docs-fix-safari-issues-with-grid-and-form-submit
github-actions
bot
temporarily deployed
to
docs-fix-safari-issues-with-grid-and-form-submit
RiinaKuu
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://funidata.atlassian.net/browse/OTM-30941
There was a bug report, that "Fieldset" legend looks of with Safari. Reason for that was how Safari handled
min-width. So for now removed a CSS line which set all grid-items min-width to 0.Also FormSubmit didn't trigger at all with Safari. Again it seems Safari handles clicks and document.activeElement differently, so now there is extra logic to make sure FormSubmit Button clicks are registered.