Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification]: Refactor component not to strict what content is contained, remove empty spaces from body text content #367

Merged
merged 16 commits into from
May 24, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented May 23, 2024

Jira ticket: https://funidata.atlassian.net/browse/DS-297

Breaking changes:

  • removed following inputs: link, externalLink, linkTitle
  • removed inner BodyText component

Migration Guidelines:

  • Application is responsible for all the content that is nested
    • so if you previously used removed Link inputs, just add a Link component inside Notification
    • If you had only text content, now it is recommended to wrap your inner text content with BodyText component

Notification Component doesn't strict what content is contained or interfere the content styling.
Also fixed body text not to include any empty space around the content text.
Updated notification documentation and tests.

…emove empty spaces from body text strings, update tests and documentation
@xanxan xanxan added the breaking change This change is not backwards-compatible label May 23, 2024
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 23, 2024 17:00 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 23, 2024 17:04 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 23, 2024 18:31 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 23, 2024 20:01 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 23, 2024 20:28 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 06:58 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 07:24 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 07:35 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 07:48 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 10:26 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 12:44 Inactive
@github-actions github-actions bot requested a deployment to docs-DS-297-notification-refactoring May 24, 2024 12:54 Abandoned
@github-actions github-actions bot temporarily deployed to docs-DS-297-notification-refactoring May 24, 2024 13:27 Inactive
@RiinaKuu RiinaKuu merged commit a1c7218 into main May 24, 2024
12 checks passed
@RiinaKuu RiinaKuu deleted the DS-297-notification-refactoring branch May 24, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants