Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heading, Section, Form]: Input property name changes: size --> variant, titleSize --> titleVariant #369

Merged
merged 14 commits into from
Jun 7, 2024
Merged

[Heading, Section, Form]: Input property name changes: size --> variant, titleSize --> titleVariant #369

merged 14 commits into from
Jun 7, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented May 24, 2024 •
edited by RiinaKuu
Loading

Jira ticket: https://funidata.atlassian.net/browse/DS-300

Breaking changes

  • Heading component: input property size --> variant
  • Section, Form components: input property titleSize --> titleVariant
  • Type FudisHeadingSize --> FudisHeadingVariant

@videoeero videoeero added the breaking change This change is not backwards-compatible label May 24, 2024
@videoeero videoeero marked this pull request as draft May 24, 2024 12:24
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 5, 2024 13:55 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 5, 2024 14:28 Destroyed
@RiinaKuu RiinaKuu marked this pull request as ready for review June 5, 2024 14:31
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 5, 2024 14:33 Destroyed
@RiinaKuu RiinaKuu changed the title [Heading, Section, Form]: Change size --> variant, add Heading variant label [Heading, Section, Form]: Change size --> variant Jun 5, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 6, 2024 06:34 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 6, 2024 06:43 Destroyed
RiinaKuu
RiinaKuu previously approved these changes Jun 6, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-300-heading-size-to-variant-and-add-label June 7, 2024 07:19 Destroyed
@RiinaKuu RiinaKuu changed the title [Heading, Section, Form]: Change size --> variant [Heading, Section, Form]: Input property name changes: size --> variant, titleSize --> titleVariant Jun 7, 2024
@RiinaKuu RiinaKuu merged commit 2693f5f into main Jun 7, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-300-heading-size-to-variant-and-add-label branch June 7, 2024 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RiinaKuu RiinaKuu RiinaKuu approved these changes

Assignees
No one assigned
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@videoeero @RiinaKuu