Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BodyText]: Rename 'size' Input to 'variant', remove 'color' Input #387

Merged
merged 12 commits into from
Jun 21, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented Jun 12, 2024

Jira-ticket: https://funidata.atlassian.net/browse/DS-318

Breaking change:

  • Renamed size Input property to variant to be consistent with Heading component's API
  • Removed color Input property. From now on the component's text color is always 'gray-dark'

@xanxan xanxan added the breaking change This change is not backwards-compatible label Jun 12, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 13, 2024 08:06 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 13, 2024 14:46 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 17, 2024 11:16 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 17, 2024 19:28 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 19, 2024 09:43 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 19, 2024 10:14 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 20, 2024 15:01 Destroyed
@RiinaKuu RiinaKuu changed the title [Body-text]: Convert input name 'size' to 'variant'" [BodyText]: Rename Input property 'size' to 'variant' Jun 20, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 20, 2024 15:14 Destroyed
@RiinaKuu RiinaKuu changed the title [BodyText]: Rename Input property 'size' to 'variant' [BodyText]: Rename 'size' Input to 'variant', remove 'color' Input Jun 20, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 20, 2024 15:45 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 20, 2024 18:24 Destroyed
…n bottom, since they are never visible simultaneously
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-318 June 21, 2024 11:41 Destroyed
@RiinaKuu RiinaKuu merged commit da3b32f into main Jun 21, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-318 branch June 21, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants