Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Link]: Remove color input, link text and external icon color is always primary-dark #391

Merged
merged 3 commits into from
Jun 20, 2024
Merged

[Link]: Remove color input, link text and external icon color is always primary-dark #391

merged 3 commits into from
Jun 20, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented Jun 19, 2024 •
edited by RiinaKuu
Loading

Jira-ticket: https://funidata.atlassian.net/browse/DS-329

Breaking change:

  • Removed color input property
    • Visible link title and possible external icon is always primary-dark. Meaning that link color stays primary-dark also inside Notification and is not transformed to gray-dark.

@xanxan xanxan added the breaking change This change is not backwards-compatible label Jun 19, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-329 June 20, 2024 14:17 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-329 June 20, 2024 14:25 Destroyed
@RiinaKuu RiinaKuu merged commit 0cad8aa into main Jun 20, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-329 branch June 20, 2024 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RiinaKuu RiinaKuu RiinaKuu approved these changes

Assignees
No one assigned
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xanxan @RiinaKuu