Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form components]: Dynamic property check on controls' updateValueAndValidity #395

Merged
merged 17 commits into from
Jun 25, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Jun 20, 2024

Jira-ticket: https://funidata.atlassian.net/browse/DS-313

Issue: Control validation was initialized once when the component was created.
Improvement: Allow control validity to be updated "on the go" reflecting e.g. other form component control values.

@videoeero videoeero added the improvement Improve or extend something that already exists label Jun 20, 2024
@videoeero videoeero marked this pull request as draft June 20, 2024 09:26
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 20, 2024 09:27 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 24, 2024 05:54 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 24, 2024 06:19 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 24, 2024 19:27 Destroyed
@MayaMarjut MayaMarjut marked this pull request as ready for review June 24, 2024 20:20
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 24, 2024 20:20 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 25, 2024 06:18 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-313-Dynamic-validator-updates June 25, 2024 07:44 Destroyed
@RiinaKuu RiinaKuu changed the title [Form components]: Dynamic property check on controls updateValueAndValidaty [Form components]: Dynamic property check on controls' updateValueAndValidity Jun 25, 2024
@RiinaKuu RiinaKuu merged commit af1caf6 into main Jun 25, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-313-Dynamic-validator-updates branch June 25, 2024 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improve or extend something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants