-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DropdownMenu]: Playwright and unit tests #405
Merged
RiinaKuu
merged 18 commits into
DS-260-expose-dropdownmenu
from
DS-260-dropdown-menu-tests
Jul 11, 2024
Merged
[DropdownMenu]: Playwright and unit tests #405
RiinaKuu
merged 18 commits into
DS-260-expose-dropdownmenu
from
DS-260-dropdown-menu-tests
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… miscellaneous file
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 2, 2024 14:04
Destroyed
RiinaKuu
changed the title
[DropdownMenu]: Unit tests
[DropdownMenu]: Playwright and unit tests
Jul 2, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 2, 2024 15:51
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 2, 2024 16:09
Destroyed
MayaMarjut
reviewed
Jul 8, 2024
|
||
expect(component.toggleMenu).toHaveBeenCalled(); | ||
|
||
expect(!!getButton().getAttribute('aria-expanded')).toEqual(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This failes if expected to be false before toggling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 9, 2024 14:45
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 9, 2024 14:47
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 10, 2024 14:23
Destroyed
…d from the component template
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 10, 2024 14:32
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 10, 2024 15:27
Destroyed
MayaMarjut
approved these changes
Jul 10, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch DS-260-dropdown-menu-tests
July 11, 2024 07:28
Destroyed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ticket: https://funidata.atlassian.net/browse/DS-260
Added unit tests for
Added Playwright tests for
Updated unit tests for