Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DropdownMenu]: Playwright and unit tests #405

Merged
merged 18 commits into from
Jul 11, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Jul 2, 2024

Jira-ticket: https://funidata.atlassian.net/browse/DS-260

Added unit tests for

  • DropdownMenuComponent
  • DropdownMenuItemComponent
  • DropdownMenuGroupComponent

Added Playwright tests for

  • DropdownMenuComponent

Updated unit tests for

  • ButtonComponent

@RiinaKuu RiinaKuu added the improvement Improve or extend something that already exists label Jul 2, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 2, 2024 14:04 Destroyed
@RiinaKuu RiinaKuu changed the title [DropdownMenu]: Unit tests [DropdownMenu]: Playwright and unit tests Jul 2, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 2, 2024 15:51 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 2, 2024 16:09 Destroyed

expect(component.toggleMenu).toHaveBeenCalled();

expect(!!getButton().getAttribute('aria-expanded')).toEqual(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This failes if expected to be false before toggling

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 9, 2024 14:45 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 9, 2024 14:47 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 10, 2024 14:23 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 10, 2024 14:32 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 10, 2024 15:27 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-260-dropdown-menu-tests July 11, 2024 07:28 Destroyed
@RiinaKuu RiinaKuu merged commit ff483eb into DS-260-expose-dropdownmenu Jul 11, 2024
8 checks passed
@RiinaKuu RiinaKuu deleted the DS-260-dropdown-menu-tests branch July 11, 2024 07:55
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improve or extend something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants