Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog]: Change Storybook example headings to h1 #409

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Jul 12, 2024

Jira-ticket: https://funidata.atlassian.net/browse/DS-321

  • Changed Storybook and docs Dialog examples to start from h1

There are discussions whether dialogs should start its semantic heading levels from 1 or 2 (or to match it with where it originally opened). However, in the IAAP WAS certificate training it was stated as follows:

There ought to be only one heading level 1, if possible, though this is not an absolute rule. A dialog should also start with a heading level 1, because a dialog is essentially a stand-alone view, almost like a mini web page.

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-dialog-fixes July 12, 2024 11:08 Destroyed
@RiinaKuu RiinaKuu added the chore Maintenance and refactoring related issue label Jul 12, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-dialog-fixes July 12, 2024 11:41 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-dialog-fixes August 1, 2024 06:39 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-dialog-fixes August 1, 2024 07:22 Destroyed
@MayaMarjut MayaMarjut merged commit f93229e into main Aug 1, 2024
10 checks passed
@MayaMarjut MayaMarjut deleted the DS-321-dialog-fixes branch August 1, 2024 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Maintenance and refactoring related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants