Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button]: Adjust left padding, remove visible focus from disabled #410

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Jul 15, 2024

Jira-ticket: https://funidata.atlassian.net/browse/DS-321

Buttons with icon and label had unnecessary left padding which caused it to look unbalanced when used with buttons without icon and placed on top of each other.

  • Removed left padding
  • Removed visible focus from disabled buttons
  • Updated Playwright tests and base images

@RiinaKuu RiinaKuu added the bug fix Something isn't working as expected label Jul 15, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-button-padding-adjustments July 15, 2024 09:22 Destroyed
@RiinaKuu RiinaKuu changed the title [Button]: Remove left padding from buttons with icon and label [Button]: Adjust left padding, remove visible focus from disabled Jul 15, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-button-padding-adjustments July 15, 2024 10:21 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-button-padding-adjustments July 15, 2024 11:12 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-321-button-padding-adjustments August 1, 2024 06:43 Destroyed
@MayaMarjut MayaMarjut merged commit 214440f into main Aug 1, 2024
10 checks passed
@MayaMarjut MayaMarjut deleted the DS-321-button-padding-adjustments branch August 1, 2024 07:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants