[Checkbox, CheckboxGroup]: Accessibility fixes (disabled state, aria-describedby) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scribedby attribute from CheckboxGroup
…text. Add unit test for aria-describedby.
…keyboard focus. Remove aria-describedby since the attribute has been moved to top level fieldset element.
…bute comes straight from the control. Fix form-dynamic-validators control order.
github-actions
bot
temporarily deployed
to
Documentation for branch DS-339-checkboxgroup-accessibility-fixes
github-actions
bot
temporarily deployed
to
Documentation for branch DS-339-checkboxgroup-accessibility-fixes
github-actions
bot
temporarily deployed
to
Documentation for branch DS-339-checkboxgroup-accessibility-fixes
github-actions
bot
temporarily deployed
to
Documentation for branch DS-339-checkboxgroup-accessibility-fixes
MayaMarjut
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ticket: https://funidata.atlassian.net/browse/DS-339
aria-describedbyvalue to Fieldset --> new Fieldset InputdescribedbyIdMain change for screen readers is that previously guidance (help text and error message) was read within each single checkbox and not the fieldset itself. Now guidance is only linked to the parent fieldset element and can be found in VoiceOver "More content" (
ctrl+option+cmd+/) info window.For visual users, tabbing through disabled checkboxes is not possible anymore. Disabled state is still communicated and focusable with screen readers.