[Dialog]: Enhance support for multiple dialogs open simultaneously #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
MayaMarjut
reviewed
Aug 19, 2024
ngx-fudis/projects/ngx-fudis/src/lib/components/dialog/ngMaterial-theme.scss
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
MayaMarjut
previously approved these changes
Aug 19, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
MayaMarjut
previously approved these changes
Aug 27, 2024
MayaMarjut
force-pushed
the
DS-324-fudis-dialog-multiple-open-closing-issue
branch
from
c39efee
to
a38548d
Compare
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
github-actions
bot
temporarily deployed
to
Documentation for branch DS-324-fudis-dialog-multiple-open-closing-issue
xanxan
approved these changes
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ticket: https://funidata.atlassian.net/browse/DS-324
Slack: https://sisudev.slack.com/archives/C33BQ29PF/p1719396453555339
Although it is not encouraged to have multiple dialogs open simultaneously, there are cases in the client app where this is the least tricky solution.
This PR aims to add better support for multiple opened dialogs.
TODO in follow up PR: