Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RadioButtonGroup, RadioButton]: New refactored components with tests #420

Merged
merged 26 commits into from
Aug 26, 2024

Conversation

MayaMarjut
Copy link
Contributor

@MayaMarjut MayaMarjut commented Aug 16, 2024

https://funidata.atlassian.net/browse/DS-270

Exposing new RadioButtonGroup and RadioButton component. New structure supports looping RadioButton child components with content projection. (This usage alignes with CheckBoxGroup component.)

Unit tests were added for both of the components. Some style adjustments included increasing clickable area around radio button. Radio button group was made visible in various form stories, which included updating related VR test.
Update value and validity example was added to Dynamic Form example story.

@MayaMarjut MayaMarjut added the feature New feature that is presented for the first time label Aug 16, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 17, 2024 14:49 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 17, 2024 15:05 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 20, 2024 06:47 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 20, 2024 09:51 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 20, 2024 10:30 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 20, 2024 11:15 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 23, 2024 08:03 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-270-Radio-button-group-improvement August 23, 2024 09:09 Destroyed
@RiinaKuu RiinaKuu merged commit a5f2eaf into main Aug 26, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-270-Radio-button-group-improvement branch August 26, 2024 06:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature that is presented for the first time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants