-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RadioButtonGroup, RadioButton]: New refactored components with tests #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 17, 2024 14:49
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 17, 2024 15:05
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 20, 2024 06:47
Destroyed
…yping, remove viewEncapsulation, update unit test
…ve focus when clicking the link in ErrorSummary
…b.com/funidata/fudis into DS-270-Radio-button-group-improvement
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 20, 2024 09:51
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 20, 2024 10:30
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 20, 2024 11:15
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 23, 2024 08:03
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-270-Radio-button-group-improvement
August 23, 2024 09:09
Destroyed
RiinaKuu
approved these changes
Aug 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://funidata.atlassian.net/browse/DS-270
Exposing new RadioButtonGroup and RadioButton component. New structure supports looping RadioButton child components with content projection. (This usage alignes with CheckBoxGroup component.)
Unit tests were added for both of the components. Some style adjustments included increasing clickable area around radio button. Radio button group was made visible in various form stories, which included updating related VR test.
Update value and validity example was added to Dynamic Form example story.