Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert, Alert Group, Alert Service]: New components and service #427

Merged
merged 28 commits into from
Sep 19, 2024
Merged

[Alert, Alert Group, Alert Service]: New components and service #427

merged 28 commits into from
Sep 19, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Sep 9, 2024

https://funidata.atlassian.net/browse/DS-269

  • Published refactored Alert Component, Alert Group Component and Alert Service
  • With these components and service we have compromised to publish them even without Sisu compatibility because Into is using them
  • Storybook documentation and unit tests updated
  • Playwright tests created

@RiinaKuu
DS-269: Expose Alert and AlertGroup components to public API
ba7252f
@RiinaKuu
DS-269: Expose AlertGroup inside Dialog template
381693f
@RiinaKuu
DS-269: Change Body Text variant logic when used inside Dialog to avo…
baea710 
…id circular dependencies
@RiinaKuu
DS-269: Refactor Alert message to Observable, add Output for clicking…
1c301b5 
… link
@RiinaKuu
DS-269: Refactor all Alert Service Signals to Observables
053e02d
@RiinaKuu
DS-269: Add exception stylings for Link and Body Text inside Alert
2cd9823
@RiinaKuu
DS-269: Update Alert Group docs and Story
9dc641e
@RiinaKuu
DS-269: Update Alert Service unit tests
64db67f
@RiinaKuu
DS-269: Create Playwright tests and base images for Alert Group
42a2575
@RiinaKuu
DS-269: Update Alert Component unit tests, remove tests that are cove…
30a13e3 
…red with VR tests
@RiinaKuu
DS-269: Update Alert Group unit tests, force change detection in Afte…
f37d4ca 
…rViewInit, refactor _visible to Observable
@RiinaKuu
DS-269: Add comment to Alert Group docs that the component is not com…
b98fc03 
…patible with Sisu (it is used in Into)
@RiinaKuu RiinaKuu added the feature New feature that is presented for the first time label Sep 9, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 9, 2024 13:41 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 9, 2024 17:31 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 10, 2024 08:26 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 11, 2024 14:56 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 12, 2024 06:38 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 13, 2024 07:01 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 19, 2024 11:46 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-269-alert September 19, 2024 11:46 Destroyed
videoeero
videoeero approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@videoeero videoeero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RiinaKuu RiinaKuu merged commit 8d1a0fb into main Sep 19, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-269-alert branch September 19, 2024 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MayaMarjut MayaMarjut MayaMarjut left review comments

@videoeero videoeero videoeero approved these changes

Assignees
No one assigned
Labels
feature New feature that is presented for the first time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiinaKuu @videoeero @MayaMarjut