[SCSS]: Style import optimizations #450
Merged
+22
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch impr-fudis-style-optimizations
videoeero
added
chore
RiinaKuu
approved these changes
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ticket: https://funidata.atlassian.net/browse/DS-380
BREAKING CHANGE:
@use '@angular/material' as mat;@include mat.core();unless application has their own additional ngMaterial uses outside Fudis.
Although style bundle of Fudis has worked well so far, it had unnecessary "double imports" on some styles. Biggest bundle bloater came from Fudis + Angular Material imports. Instructions and Storybook have been now adjusted to avoid double import of ngMaterial.
This is marked as Breaking Change, as previously we have instructed applications to import both Fudis and ngMaterial in the root style file, but now importing ngMaterial should be unnecessary.