Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FudisLocalizedTextGroupOption & FudisLocalizedTextGroup]: Changed default controlName values #451

Conversation

MayaMarjut
Copy link
Contributor

@MayaMarjut MayaMarjut commented Oct 1, 2024

https://funidata.atlassian.net/browse/DS-354

Client requested to change the default controlName values for FudisLocalizedTextGroupOption and FudisLocalizedTextGroup. Eventhough these names can be overriden, decided to do this change in order to help it's usage. Updated documentation.

Changes to Label Component's CSS display and wrapping. Overflow wrapping was removed after Into findings on certain TextInput label. This fixes the current issue but might cause another issue if label has really long words (it does not wrap it anymore). Assumption is that labels do not have that long words.

@MayaMarjut MayaMarjut added the breaking change This change is not backwards-compatible label Oct 1, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions October 1, 2024 16:05 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions October 2, 2024 05:30 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions October 2, 2024 10:48 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions October 2, 2024 13:35 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions October 3, 2024 06:39 Destroyed
@RiinaKuu RiinaKuu merged commit 6cfd507 into main Oct 3, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-354-Changing-default-controlName-value-for-FudisLocalizedTextGroupOptions branch October 3, 2024 07:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants