Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: There's raw domain output, but no raw IP output. #268

Closed
T145 opened this issue Nov 8, 2021 · 2 comments
Closed

FEATURE: There's raw domain output, but no raw IP output. #268

T145 opened this issue Nov 8, 2021 · 2 comments

Comments

@T145
Copy link

T145 commented Nov 8, 2021

Description

It would be nice if there were a way to get directly IPs rather than from just the hosts file output.

Possible Solution

On that note, it would also be great to at least leave hosts_ip empty and then output raw lists under hosts.
This would probably be the better option as opposed to having separate "domains" and "ips" outputs.
Then the present "domains" output becomes obsolete.

Considered Alternative

Generating an "ips" output, but it's lazy.

Additional context

It may also be worth considering how to handle IPv6 addresses.

@spirillen
Copy link
Contributor

A good idea. I defiantly second that as I handle IP my self both for firewall like nftables and RPZ zones, haven a clear & clean (IP|IP/CIDR) would be a nice feature.

@funilrys funilrys moved this to Waiting for Triage in #PyFunceble Features Oct 7, 2022
@funilrys funilrys moved this from Waiting for Triage to To do in #PyFunceble Features Oct 7, 2022
@funilrys funilrys moved this to 📋 Backlog in PyFunceble Backlog Oct 25, 2022
@funilrys funilrys moved this from 📋 Backlog to 🏗 In progress in PyFunceble Backlog May 27, 2023
@github-project-automation github-project-automation bot moved this from To do to Done in #PyFunceble Features May 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in PyFunceble Backlog May 28, 2023
@funilrys
Copy link
Owner

By the way, not that this has been fixed, I wanted to explain the reason why ips weren't "first-class citizens" among the plain output format.

Back when I developed funceble - for my own usage, funceble was a tool that was highly hosts-file oriented. As IPs are useless into hosts files, I used that method to filter out IPs.

Now that this tool is used by many others, it was time to fix this. Sorry for the waiting time @T145, the last 2-3 years have been hard - privately.

Stay safe and healthy.

funilrys added a commit that referenced this issue May 29, 2023
Fixed:
  * Security / Dependency Management: cryptography
    Mitigation of CVE-2023-0286 & CVE-2023-23931 through
    version bump.
  * Fatal Error: When no nameservers are configured or provided by the
    hosting system. (#328)
  * Semantic: git.io (#341)
    URLs with git.io were replaced with other one.
  * New linting issues.

Improved:
  * SPECIAL Rules: weebly.com
    We now take down subdomains that return the 406 status code.
  * SPECIAL Rules: wordpress.com (#321)
    We now recognize subjects that were took down by Wordpress.
  * SPECIAL Rules: internal
    Uniformiization of the method for better and quicker development.
  * Dependency Management: sqlalchemy
    We upgraded to SQLAlchemy v2.x+.
  * Converters: internal
    Convertion can now be performed directely without initialization of
    subjects through the convet method.

Removed:
  * Python Support: <=3.7
    We do not test or support any usage of PyFunceble with python<=3.7.

New:
  * Python Support: ~=3.11
    We now test (CI/CD) and support python~=3.11.
  * Testing: pytest (#328)
    pytest can now be used by packager to tests pyfunceble before
    deployment.
  * Database: PostgreSQL
    We now support PostgreSQL as database type.
  * Filesystem: IPs as first-class citizens in plain text outputs (#268)
    From now on, IPs will be stored into the `ips` subdirectory when the
    plain text format is active.
  * SPECIAL Rules: subject-switch (#185 | #185#issuecomment-1290866362)
    We now support the subject switch from any domains.
    For example:

    - m.example.com -> example.com
      Outcome: m.example.com as INACTIVE
    - m.example.com -> example.org
      Outcome: NO status switch.
    - m.example.com -> a.example.com -> example.com
      Outcome: m.example.com as INACTIVE.
    - m.example.com/hello/world -> example.com/hello/world
      Outcome: m.example.com/hello/world as INACTIVE.
  * SPECIAL Rules: changeip (#311)
    When one of the known changeip domains provides `abuse.change.com`
    in the SOA record, the subject will be flagged as INACTIVE.
  * SPECIAL Rules: imgur.com (#319)
    We now flag removed images.
  * SPECIAL Rules: eToxic (#334)
    When a blog from the eToxic infrastructure (known domains) doesn't
    exists anymore, we flag them as INACTIVE.

Contributors:
  * @Nilsonfsilva
  * @smed79
  * @spirilln
  * @T145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants