Skip to content

Commit

Permalink
fix daisy permanently hanging
Browse files Browse the repository at this point in the history
In the case where the check function skips all blocks of a given task, `_recruit_workers` never got called and daisy would just hang
  • Loading branch information
pattonw committed May 9, 2024
1 parent d60ef45 commit a5799b9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions daisy/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,12 @@ def _handle_acquire_block(self, message):
)

self._send_client_message(message.stream, RequestShutdown())
# in the case that the scheduler skips all blocks for a task
# because that task has previously been recruited, we now
# have tasks available to start that will hang forever unless
# started now since no more blocks are available for the existing
# task and no workers are running.
self._recruit_workers()

return

Expand Down

0 comments on commit a5799b9

Please sign in to comment.