Skip to content

Commit

Permalink
build: drop python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
tlambert03 committed Oct 24, 2024
1 parent 5b71b19 commit 463e65d
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,17 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.10", "3.11"]
python-version: ["3.10", "3.11", "3.12"]
platform: [ubuntu-latest, windows-latest]
include:
- python-version: "3.9"
platform: ubuntu-latest
- python-version: "3.8"
platform: macos-13
- python-version: "3.9"
platform: macos-13
- python-version: "3.10"
platform: macos-latest
- python-version: "3.11"
platform: macos-latest
- python-version: "3.12"
platform: ubuntu-latest

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -87,7 +83,7 @@ jobs:
python setup.py build_ext --inplace # required for C coverage
env:
CYTHON_TRACE: 1 # enable coverage of cython code
CFLAGS: '-coverage' # enable coverage of C code
CFLAGS: "-coverage" # enable coverage of C code

- name: run tests
run: |
Expand All @@ -100,7 +96,7 @@ jobs:
uses: codecov/codecov-action@v4
with:
files: ./coverage.xml,./coverage_cpp.xml

# we only deploy the sdist to PyPI, the wheel is still complicated
deploy-sdist:
if: startsWith(github.ref, 'refs/tags')
Expand Down
3 changes: 2 additions & 1 deletion ilpy/_functional.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

from typing import TYPE_CHECKING, Callable, Iterable, Literal, Mapping, Sequence, Tuple
from collections.abc import Iterable, Mapping, Sequence
from typing import TYPE_CHECKING, Callable, Literal, Tuple

from .expressions import Expression
from .wrapper import (
Expand Down
3 changes: 2 additions & 1 deletion ilpy/expressions.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
from __future__ import annotations

import ast
from typing import Any, ClassVar, Sequence, Union
from collections.abc import Sequence
from typing import Any, ClassVar, Union

from ilpy.wrapper import Constraint, Objective, Relation, Sense

Expand Down
3 changes: 2 additions & 1 deletion ilpy/wrapper.pyi
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from collections.abc import Iterable, Mapping, Sequence
from enum import IntEnum, auto
from typing import TYPE_CHECKING, Callable, Iterable, Mapping, Sequence
from typing import TYPE_CHECKING, Callable

if TYPE_CHECKING:
LinearCoeffs = Sequence[float] | Mapping[int, float]
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"
[project]
name = "ilpy"
description = "Python wrappers for popular MIP solvers."
requires-python = ">=3.8"
requires-python = ">=3.9"
license = { text = "MIT" }
authors = [
{ email = "funkej@janelia.hhmi.org", name = "Jan Funke" },
Expand Down Expand Up @@ -48,7 +48,7 @@ readme = { file = ["README.md"] }

# https://beta.ruff.rs/docs
[tool.ruff]
target-version = "py38"
target-version = "py39"
src = ["ilpy"]

[tool.ruff.lint]
Expand Down
3 changes: 2 additions & 1 deletion tests/test_solvers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import operator
import os
from typing import Iterable, NamedTuple, Sequence
from collections.abc import Iterable, Sequence
from typing import NamedTuple
from unittest.mock import Mock

import ilpy
Expand Down

0 comments on commit 463e65d

Please sign in to comment.