Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find gurobi if present, test on ci #2

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Mar 2, 2023

this PR:

  1. adds the gurobi_c.h header, allowing us to build against gurobi if the library is present (installation of that is still, at this point, left to the user)
  2. moves the logic from config.h into setup.py: we no longer hard-code HAVE_GUROBI, it will be determined at buildtime
  3. sets up CI to build the package and run tests
  4. xfails the gurobi test if no license is present
  5. removes requirements.txt files and puts them into setup.py dev extra (use pip install -e .[dev])

@tlambert03
Copy link
Member Author

i'm going to optimistically merge this one to get the CI to run, it doesn't touch the cor library (and the new tests won't run on CI unless it's in master)

@tlambert03 tlambert03 merged commit 79357eb into funkelab:master Mar 2, 2023
@tlambert03 tlambert03 deleted the opt-gurobi branch March 2, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant