Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotly plotting from motile #15

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Add plotly plotting from motile #15

merged 4 commits into from
Jul 25, 2024

Conversation

cmalinmayor
Copy link
Collaborator

@cmalinmayor cmalinmayor commented Jul 24, 2024

Proposed Change

Move the plotly plotting from motile into the toolbox.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 89.52381% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (f3c353b) to head (d11b564).

Files Patch % Lines
...motile_toolbox/visualization/plot_motile_graphs.py 89.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   84.37%   87.05%   +2.68%     
==========================================
  Files          13       14       +1     
  Lines         320      425     +105     
==========================================
+ Hits          270      370     +100     
- Misses         50       55       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor cmalinmayor merged commit 499b26f into main Jul 25, 2024
4 checks passed
@cmalinmayor cmalinmayor deleted the add_motile_plots branch July 25, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants