Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multihypothesis segmentation handling #24

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

cmalinmayor
Copy link
Collaborator

@cmalinmayor cmalinmayor commented Nov 26, 2024

Proposed Change

Make different functions for creating candidate graphs from single and multihypothesis segmentations. This makes it simpler to use in the normal case (one hypothesis), avoiding having to add a dummy hypothesis dimension.
Note: This is a breaking change to the public API, since I renamed all the construct graph functions.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (4ca103e) to head (2ffe2c5).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   87.18%   87.75%   +0.56%     
==========================================
  Files          14       14              
  Lines         437      449      +12     
==========================================
+ Hits          381      394      +13     
+ Misses         56       55       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor
Copy link
Collaborator Author

Closes #23

@cmalinmayor cmalinmayor linked an issue Nov 26, 2024 that may be closed by this pull request
Copy link
Collaborator

@msschwartz21 msschwartz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verbal comments :)

src/motile_toolbox/candidate_graph/utils.py Show resolved Hide resolved
@cmalinmayor cmalinmayor merged commit 4986526 into main Nov 26, 2024
4 checks passed
@cmalinmayor cmalinmayor deleted the 23-remove-hypo-dim branch November 26, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused hypothesis dimension
3 participants