Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tests #50

Merged
merged 2 commits into from
Jun 30, 2024
Merged

ci: fix tests #50

merged 2 commits into from
Jun 30, 2024

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Jun 29, 2024

closes #47

see also funkelab/ilpy-feedstock#5

@tlambert03
Copy link
Member Author

here ya go @cmalinmayor ... we can cut a new release of ilpy that simply hard pins scip. Not super flexible and won't play well with others that want a more flexible pinning, but I'm not sure how to build against one version and end up with another one at the moment

@tlambert03 tlambert03 changed the title ci: try fixing tests ci: fix tests Jun 29, 2024
@tlambert03 tlambert03 merged commit b43fd0e into funkelab:main Jun 30, 2024
6 checks passed
@tlambert03
Copy link
Member Author

whoops... I'm sorry, I didn't mean to merge this into main without your review @cmalinmayor

Looks like stuff is passing, but here's the diff of stuff I accidentally merged in case you want to undo any of it:

https://github.com/funkelab/motile_napari_plugin/compare/ff667079c2ae7a40cd77886a1f2f5f7d0b20b83f..77155746e3a32cb625cc3cbeccc685a09f7c2dcc

@tlambert03
Copy link
Member Author

the ilpy problem is fixed upstream now, so i briefly pinned scip here, and then unpinned it

@cmalinmayor
Copy link
Collaborator

Thanks Talley! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests workflow
2 participants