convert all graph data where necessary before saving to make it json serializable #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmalinmayor
reviewed
Oct 21, 2024
| if not isinstance(self.time_attr, np.ndarray) | ||
| else self.time_attr.tolist(), | ||
| "time_attr": ( | ||
| self.time_attr.astype( |
There was a problem hiding this comment.
What is this part for? We aren't saving the time values, just the actual time attribute, which should be a string.
There was a problem hiding this comment.
oops you're right, that is a mistake! I forgot to remove that when I pushed.
There was a problem hiding this comment.
Phew okay good! I removed it, so I think I can merge now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the np.uint64 is not json serializable error that pops up when saving the tracks after you have added new nodes with the points or labels layer.