Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzing test against built-in array #69

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

dubzzz
Copy link
Contributor

@dubzzz dubzzz commented Sep 7, 2018

Related to #67 and #68

The bugs seems really tricky and rare, I did use the option { numRuns: 10000 } of fc.assert to make the test less flaky locally (to fail everytime).

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #69 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/curried.ts 100% <0%> (ø) ⬆️
src/index.ts 98.99% <0%> (+0.1%) ⬆️

@dubzzz
Copy link
Contributor Author

dubzzz commented Feb 21, 2019

@paldepind Do you want me to commit the fuzzer test suite?
I can rebase the review if needed

@paldepind
Copy link
Member

Oh. I forgot about this 😓

Yes! I'd definitely like to merge this. Please rebase 😄

@dubzzz
Copy link
Contributor Author

dubzzz commented Feb 24, 2019

I just rebased it.

If you encounter failing cases for which fast-check takes too long, please let me know.
I am still working on reducing the time it takes to shrink commands, arrays and all other data-structures. For the moment, the solution is to use noShrink but I am thinking on adding some kind of time limit after which shrinking will be stopped dubzzz/fast-check#286

@paldepind
Copy link
Member

Thanks a lot @dubzzz. This looks good to me and seems to work great 👍

@paldepind paldepind merged commit 6a21d51 into funkia:master Mar 13, 2019
@dubzzz dubzzz deleted the fuzzing branch March 13, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants