Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch invalid colors #779

Open
simonv3 opened this issue Jun 19, 2024 · 4 comments · May be fixed by #832
Open

Catch invalid colors #779

simonv3 opened this issue Jun 19, 2024 · 4 comments · May be fixed by #832
Labels
bug Something isn't working frontend good first issue Good for newcomers

Comments

@simonv3
Copy link
Member

simonv3 commented Jun 19, 2024

if you input an invalid color here (by removing the hashtag, for instance), the corresponding elements become invisible

We should use this regex on validation

"^#([A-Fa-f0-9]{6}|[A-Fa-f0-9]{3})$"
@simonv3 simonv3 added bug Something isn't working good first issue Good for newcomers frontend labels Jun 19, 2024
@vihdzp
Copy link
Collaborator

vihdzp commented Jun 19, 2024 •
edited
Loading

Would it maybe be easier to display the hashtag separately on an immutable label? That way you can't delete it by accident.

Also, if colors with an alpha channel are a desired feature, four or eight letters and numbers would also be valid.

simonv3 pushed a commit that referenced this issue Jun 21, 2024
fix: improvements to do with color validation
f54d709 
to do with #779
@simonv3
Copy link
Member Author

simonv3 commented Jun 22, 2024

Just added some simple "hey that's not a real color" checking.

@bruno-corso
Copy link

where is this? I'd like to help but i can't find this on the website

@simonv3
Copy link
Member Author

simonv3 commented Jun 25, 2024

@bruno-corso If you create an artist, it's under "edit details" which takes you to the "manage/artists/:artistId/customize" view. The CustomizeLook component dictates whether a user first chooses a theme, or whether they're editing colors.

@peterklingelhofer peterklingelhofer linked a pull request Sep 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show color invalid error peterklingelhofer/mirlo
3 participants
@simonv3 @vihdzp @bruno-corso