Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show color invalid error #832

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Show color invalid error #832

wants to merge 3 commits into from

Conversation

peterklingelhofer
Copy link
Collaborator

@peterklingelhofer peterklingelhofer commented Sep 2, 2024 •
edited
Loading

Closes #779

@peterklingelhofer peterklingelhofer added the enhancement New feature or request label Sep 2, 2024
@peterklingelhofer peterklingelhofer self-assigned this Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

✅ Deploy Preview for mirlo ready!

Name Link
🔨 Latest commit 0decc5c
🔍 Latest deploy log https://app.netlify.com/sites/mirlo/deploys/66d5ee9e54ed120008787667
😎 Deploy Preview https://deploy-preview-832--mirlo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peterklingelhofer peterklingelhofer changed the title Show color invalid error, improve color validation regex Show color invalid error Sep 2, 2024
@simonv3
Copy link
Member

simonv3 commented Sep 3, 2024

My thought here was that this would show that a color is not valid as a user is typing it? Maybe that's already the case though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonv3 simonv3 Awaiting requested review from simonv3

At least 1 approving review is required to merge this pull request.

Assignees

@peterklingelhofer peterklingelhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Catch invalid colors
2 participants
@peterklingelhofer @simonv3