feat: Create a favicon for an artist based on their avatar #912
+3,969
−7,352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the sharp-ico package and tried to generate a favicon based on the artist avatar we have.
👷 Deploy request for mirlo pending review.Visit the deploys page to approve it
|
Fixed comment to match JS style comments
simonv3
reviewed
Nov 21, 2024
src/jobs/optimize-image.ts
Outdated
| @@ -148,6 +150,17 @@ const optimizeImage = async (job: Job) => { | |||
| data: { url: urls }, | |||
| }); | |||
| } else if (model === "artistAvatar") { | |||
| // TODO: where should the favicon be stored | |||
There was a problem hiding this comment.
We can store it on minio, for which there's a utility library in minio.ts.
You can see an example of it being used here https://github.com/funmusicplace/mirlo/pull/912/files#diff-115f11f048b07ecdfa25349373f3479306ff732a6f8185f5590f98f114d211dbR114
Added call to upload the artist avatar favicon to the Minio store and some logging to indicate when it happens
lenikadali
commented
Nov 27, 2024
src/jobs/optimize-image.ts
Outdated
Comment on lines
152
to
162
| artistFavicon = ico.sharpsToIco([sharp(buffer)], "artist_avatar.ico", { | ||
| sizes: [48], | ||
| resizeOptions: {}, | ||
| }); | ||
| logger.info("Uploading artist avatar favicon to bucket"); | ||
| const faviconFinalName = `${destinationId}_favicon.ico`; | ||
| await minioClient.putObject( | ||
| finalMinioBucket, | ||
| faviconFinalName, | ||
| artistFavicon | ||
| ); |
There was a problem hiding this comment.
@simonv3 I've tried to store the favicon in Minio as you suggested. Let me know if I got it right 😅 🙏
There was a problem hiding this comment.
That looks good! If you're running this locally, you can check to see if it ended up there, instructions on how to access it here: https://github.com/funmusicplace/mirlo?tab=readme-ov-file#minio
Removed the artistFavicon variable since the return value of the ico method is the size, width and height properties of the favicon. Switch to setting the file name as a variable and use that when saving the favicon to the Minio bucket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330