Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kioskboard writes numbers backwards when input type=number #1

Closed
surexxx opened this issue Aug 17, 2020 · 4 comments
Closed

Kioskboard writes numbers backwards when input type=number #1

surexxx opened this issue Aug 17, 2020 · 4 comments
Assignees
@furcan
Labels
bug Something isn't working fixed Has been fixed.

Comments

@surexxx
Copy link
Contributor

surexxx commented Aug 17, 2020

Is it normal when I set input type=number the kiskboard with default config writes numbers backwards?
For example: I press number buttons in order 1 2 3 and it writes 3 2 1 to html input.

image

Is there a way to configure it to works as input type=tel?

image
@furcan furcan added bug Something isn't working question Further information is requested labels Aug 17, 2020
@furcan furcan self-assigned this Aug 17, 2020
@furcan
Copy link
Owner

furcan commented Aug 17, 2020

Hi @surexxx

Firstly thank you for using the KioskBoard.

Unfortunately, Chromium not allowing the "selectionStart" and the "selectionEnd" for the input elements if the type is "number". This is the why of this issue happening.

So,

I created a solution to fix this, but I will wait a little bit to release the new version (as soon as possible). Because I already planned to do some improvements for the KioskBoard. Also, this fix will be included in the next version.

Thanks.

Furkan.

@surexxx
Copy link
Contributor Author

surexxx commented Aug 18, 2020

@furcan thanks for quick answer. I found a workaround: set "type=tel" and it works as I expected... pls update this thread if update released.

furcan pushed a commit that referenced this issue Aug 19, 2020
Version 1.3.0 Released.
8ef73a4 
Changed: `kioskboard.css`, and `kioskboard.js` files have been moved from `dist` folder to `src` folder.

Changed: `kioskboard-aio.js` file has been moved from `dist` folder to `src/all-in-one` folder.

Added: `autoScroll` option has been added. Scrolling the document to the top of the input/textarea element can be manageable with this option. The default value is `true` as before.

Fixed: Fixes for the input element's `selectionStart` method to prevent issues if the input element type is number. ([#1](#1))

Changed: Code Review.
furcan added a commit that referenced this issue Aug 19, 2020
@furcan
Version 1.3.0 Released.
612082e 
Changed: `kioskboard.css`, and `kioskboard.js` files have been moved from `dist` folder to `src` folder.

Changed: `kioskboard-aio.js` file has been moved from `dist` folder to `src/all-in-one` folder.

Added: `autoScroll` option has been added. Scrolling the document to the top of the input/textarea element can be manageable with this option. The default value is `true` as before.

Fixed: Fixes for the input element's `selectionStart` method to prevent issues if the input element type is number. ([#1](#1))

Changed: Code Review.
@furcan
Copy link
Owner

furcan commented Aug 19, 2020

Hi @surexxx .

This issue has been fixed.
Changelog.

Thanks.

@furcan furcan closed this as completed Aug 19, 2020
@furcan furcan added fixed Has been fixed. and removed question Further information is requested labels Aug 19, 2020
@surexxx
Copy link
Contributor Author

surexxx commented Aug 19, 2020

It is now working in version 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@furcan furcan

Labels
bug Something isn't working fixed Has been fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surexxx @furcan