Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KioskBoard doesn't support IE #3

Closed
surexxx opened this issue Aug 19, 2020 · 1 comment
Closed

KioskBoard doesn't support IE #3

surexxx opened this issue Aug 19, 2020 · 1 comment
Labels
enhancement New feature or request fixed Has been fixed.

Comments

@surexxx
Copy link
Contributor

surexxx commented Aug 19, 2020

Hi @furcan
I see that kioskboard is not working on IE, need some polyfill to resolve this issue. The good news is that we have done it. Could you please insert it to the right place?

(function () {
    if (typeof window.Event === "function") return false; //kioskboard on IE (IE: typeof window.Event is object, othe browsers: typeof window.Event is function)

    function Event(event, params) {
        params = params || { bubbles: false, cancelable: false, detail: undefined };
        var evt = document.createEvent('CustomEvent');
        evt.initCustomEvent(event, params.bubbles, params.cancelable, params.detail);
        return evt;
    }

    Event.prototype = window.Event.prototype;

    window.Event = Event;
})();
@surexxx surexxx changed the title KioskBoard not supports IE KioskBoard don't supports IE Aug 19, 2020
@surexxx surexxx changed the title KioskBoard don't supports IE KioskBoard doesn't support IE Aug 19, 2020
@furcan furcan added the enhancement New feature or request label Aug 19, 2020
furcan added a commit that referenced this issue Aug 19, 2020
Fixed: Fixes on checking the "window.location.protocol". ([#4](#4))

Added: IE polyfill for the CustomEvent constructor. ([#3](#3))

Changed: Code Review.
furcan added a commit that referenced this issue Aug 19, 2020
Added: Internet Explorer 11 compatibility. ([#3](#3))

Changed: Code Review.
@furcan
Copy link
Owner

furcan commented Aug 19, 2020

Hi @surexxx

KioskBoard can be used in IE 11 now.
CHANGELOG

Thanks.

@furcan furcan closed this as completed Aug 19, 2020
@furcan furcan added the fixed Has been fixed. label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Has been fixed.
Projects
None yet
Development

No branches or pull requests

2 participants