Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom key with multiple characters #31

Closed
skullab opened this issue Nov 28, 2021 · 4 comments
Closed

Custom key with multiple characters #31

skullab opened this issue Nov 28, 2021 · 4 comments
Assignees
@furcan
Labels
bug Something isn't working fixed Has been fixed.

Comments

@skullab
Copy link

skullab commented Nov 28, 2021

if I create a key that inserts more characters, it is no longer possible to delete the input because the length of the input
exceeds the length of the aray where the characters are saved. I have created a fork to solve this problem.
https://github.com/skullab/KioskBoard
@skullab skullab mentioned this issue Nov 28, 2021
Closed
@furcan
Copy link
Owner

furcan commented Nov 29, 2021

Hi @skullab ,

Thanks for the report.

Could you please share your init function(especially the keys) for reproducing the issue on my local? And also, I will review the PR as well.

Thanks,
Furkan.

@furcan furcan self-assigned this Nov 29, 2021
@skullab
Copy link
Author

skullab commented Nov 29, 2021 

keysArrayOfObjects = [
     // other object rows configurations...
     {
        "0":".com"
        // and so on...
     },
]

In this case, when I press the key, the ".com" value is entered correctly, but it is no longer possible to delete the input with the backspace key.

@furcan
Copy link
Owner

furcan commented Dec 7, 2021

Hi @skullab

FYI => #32

Thanks.

@furcan furcan added the bug Something isn't working label Dec 11, 2021
furcan added a commit that referenced this issue Dec 11, 2021
@furcan
Version 2.0.0
b4a897c 
Removed: The `KioskBoard.Merge()` method has been removed. (This method already has been deprecated in v1.4.0)

Changed: `KioskBoard.Init()` function name has been changed to `KioskBoard.init()`.

Changed: `KioskBoard.Run()` function name has been changed to `KioskBoard.run()`.

Changed: Auto-generated `kioskboard-aio.js` file has been moved from `src/all-in-one` folder to `build` folder.

Changed: The `specialCharactersObject` option has been changed to `keysSpecialCharsArrayOfStrings`. An Array of Strings can be set to override the built-in special characters. e.g. => `["#", "$", "%", "+", "-", "*"]`

Fixed: Custom key with multiple characters: ([#31](#31))

Added: The `keysNumpadArrayOfNumbers` option has been added: An Array of Numbers can be set to override the built-in numpad keys. (From 0 to 9, in any order.) e.g. => `[1, 2, 3, 4, 5, 6, 7, 8, 9, 0]` - ([#30](#30))
@furcan
Copy link
Owner

furcan commented Dec 11, 2021

Hi @skullab ,

KioskBoard v2.0.0 has been released. This issue has been fixed with this release. Also, this is a major release. Please take a look at the CHANGELOG before updating your current projects.

Thanks,
Furkan.

@furcan furcan closed this as completed Dec 11, 2021
@furcan furcan added the fixed Has been fixed. label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@furcan furcan

Labels
bug Something isn't working fixed Has been fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skullab @furcan