Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long press feature #53

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Add long press feature #53

merged 4 commits into from
Apr 12, 2022

Conversation

surexxx
Copy link
Contributor

@surexxx surexxx commented Apr 6, 2022

Long press of kioskboard buttons don't work in Android devices. This change fixes the problem listening 'contextmenu' and 'touchend' events.

Long press of kioskboard buttons don't work in Android devices. This change fixes the problem listening 'contextmenu' and 'touchend' events.
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
src/kioskboard.js Outdated Show resolved Hide resolved
@surexxx
Copy link
Contributor Author

surexxx commented Apr 11, 2022

@furcan I've done all your requested changes.

@furcan
Copy link
Owner

furcan commented Apr 11, 2022

@furcan I've done all your requested changes.

Hi @surexxx
I think rebasing from main branch has broke your PR. Can you please check?

@surexxx
Copy link
Contributor Author

surexxx commented Apr 11, 2022

Ohh my God. Tabs and spaces. I'll correct them.

@furcan furcan merged commit ff4c54c into furcan:main Apr 12, 2022
furcan added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants