check cron expression valid #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2022 14:35
irvinlim
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
@qingyuanz Thanks for your PR 😄 we should also probably update the version in the https://github.com/furiko-io/furiko project as well!
|
LGTM! 🙇 |
|
@qingyuanz Tagged as v0.1.3 (in order to maintain parity with internal tags). We could proceed to update the main furiko code now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is parsing some wrong expression, like (*/2 * * 10-5 *), when calling Next(), it panics in some cases.
So should check the cron expression valid first.