Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller crash when deleting a JobConfig #101

Closed
irvinlim opened this issue Aug 3, 2022 · 0 comments · Fixed by #103
Closed

Controller crash when deleting a JobConfig #101

irvinlim opened this issue Aug 3, 2022 · 0 comments · Fixed by #103
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@irvinlim
Copy link
Member

irvinlim commented Aug 3, 2022

Observed panic when deleting a JobConfig that has no schedule set:

panic: time: missing Location in call to Time.In

goroutine 259 [running]:
time.Time.In(...)
        /usr/local/go/src/time/time.go:1105
github.com/furiko-io/furiko/pkg/execution/util/schedule.(*Schedule).Bump(0xc0004d12f0?, 0xc00060cf00?, {0x40d425?, 0x7f81f46e2b00?, 0x29e0220?})
        /go/src/github.com/furiko-io/furiko/pkg/execution/util/schedule/schedule.go:153 +0x5f9
github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller.(*CronWorker).refreshUpdatedJobConfigs(0xc00003a780, {0x1a96bb4?, 0x22?, 0x29e0220?})
        /go/src/github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller/cron_worker.go:192 +0x2bf
github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller.(*CronWorker).Work(0xc00003a780)
        /go/src/github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller/cron_worker.go:129 +0x258
github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller.instrumentWorkerMetrics.func1()
        /go/src/github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller/metrics.go:30 +0x62
github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller.ClockTickUntil(0xc0004c7420, 0x0?, 0xc00041d0e0)
        /go/src/github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller/ticker.go:42 +0x247
created by github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller.(*CronWorker).Start
        /go/src/github.com/furiko-io/furiko/pkg/execution/controllers/croncontroller/cron_worker.go:98 +0x12a
@irvinlim irvinlim added the kind/bug Categorizes issue or PR as related to a bug. label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant