Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gracefully handle no schedule in Bump() #103

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Dec 5, 2022

Closes #101.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 63.50% // Head: 63.53% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (812082d) compared to base (5ad6ccc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   63.50%   63.53%   +0.03%     
==========================================
  Files         205      205              
  Lines       10958    10957       -1     
==========================================
+ Hits         6959     6962       +3     
+ Misses       3621     3619       -2     
+ Partials      378      376       -2     
Impacted Files Coverage Δ
pkg/execution/util/schedule/schedule.go 77.32% <100.00%> (+1.60%) ⬆️
pkg/utils/heap/heap.go 100.00% <0.00%> (+1.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irvinlim irvinlim marked this pull request as ready for review December 6, 2022 15:14
@irvinlim irvinlim merged commit 7f7ea19 into main Dec 6, 2022
@irvinlim irvinlim deleted the irvinlim/fix/nil-location branch December 6, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller crash when deleting a JobConfig
1 participant