Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support maxConcurrency #16

Closed
irvinlim opened this issue Mar 25, 2022 · 0 comments · Fixed by #92
Closed

Feature: Support maxConcurrency #16

irvinlim opened this issue Mar 25, 2022 · 0 comments · Fixed by #92
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.

Comments

@irvinlim
Copy link
Member

irvinlim commented Mar 25, 2022 •
edited
Loading

Currently, using ConcurrencyPolicyForbid and ConcurrencyPolicyEnqueue will drop or enqueue Jobs if there is another concurrently running Job. We want to support this behavior but for N concurrently running Jobs.

This should be a trivial extension of the existing logic, but some design is needed.

Open design questions:

  1. This should not apply to ConcurrencyPolicyAllow at all I think, otherwise it makes it identical to ConcurrencyPolicyForbid.
    • Another way, it should not apply to ConcurrencyPolicyForbid but instead put a maximum on ConcurrencyPolicyAllow.
  2. Another way is to drop ConcurrencyPolicyAllow altogether, and only support Forbid or Enqueue, with an additional maxConcurrency field. This might result in some slight logical changes in places that interpret the concurrency policy.
@irvinlim irvinlim added good first issue Good for newcomers area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. labels Mar 25, 2022
@irvinlim irvinlim added area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) and removed good first issue Good for newcomers area/api Related to public APIs, including CRD design, configuration, etc labels Apr 11, 2022
@irvinlim irvinlim added this to the Alpha Release milestone Apr 22, 2022
@irvinlim irvinlim mentioned this issue Apr 30, 2022
Closed
@irvinlim irvinlim removed this from the v0.2.0 milestone Jun 5, 2022
@irvinlim irvinlim mentioned this issue Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(concurrency): Support variable MaxConcurrency furiko-io/furiko
1 participant
@irvinlim