Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(concurrency): Support variable MaxConcurrency #92

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Jun 7, 2022

Closes #16.

Implements MaxConcurrency in ConcurrencySpec, which allows specifying a custom maximum concurrency value. This applies to both Forbid and Enqueue.

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) labels Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #92 (9676753) into main (bdc131a) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   63.28%   63.25%   -0.04%     
==========================================
  Files         203      203              
  Lines       10722    10735      +13     
==========================================
+ Hits         6785     6790       +5     
- Misses       3571     3581      +10     
+ Partials      366      364       -2     
Impacted Files Coverage Δ
...xecution/controllers/jobqueuecontroller/control.go 0.00% <0.00%> (-48.65%) ⬇️
...ution/controllers/jobqueuecontroller/controller.go 28.75% <0.00%> (-0.74%) ⬇️
apis/execution/v1alpha1/jobconfig_types.go 100.00% <100.00%> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 59.64% <100.00%> (+0.59%) ⬆️
...execution/controllers/croncontroller/reconciler.go 81.92% <100.00%> (+0.22%) ⬆️
...llers/jobqueuecontroller/reconciler_independent.go 79.36% <100.00%> (-1.52%) ⬇️
...lers/jobqueuecontroller/reconciler_perjobconfig.go 74.62% <100.00%> (+12.86%) ⬆️
pkg/execution/validation/validation.go 91.03% <100.00%> (+0.19%) ⬆️
...kg/execution/controllers/croncontroller/metrics.go 14.28% <0.00%> (-85.72%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc131a...9676753. Read the comment docs.

@irvinlim irvinlim force-pushed the irvinlim/feat/max-concurrent branch from 7cbf420 to ca2e39b Compare June 9, 2022 15:42
@irvinlim irvinlim merged commit a77a1c7 into main Jun 11, 2022
@irvinlim irvinlim deleted the irvinlim/feat/max-concurrent branch June 11, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support maxConcurrency
1 participant