Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Jobs created independently of JobConfig ignore startAfter #17

Closed
irvinlim opened this issue Mar 25, 2022 · 0 comments · Fixed by #56
Closed

Bug: Jobs created independently of JobConfig ignore startAfter #17

irvinlim opened this issue Mar 25, 2022 · 0 comments · Fixed by #56
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/bug Categorizes issue or PR as related to a bug.

Comments

@irvinlim
Copy link
Member

If the Job is created independently (see the website for explanation), then it uses a different reconciler queue in the JobQueueController to be started. However, the startAfter is ignored entirely.
@irvinlim irvinlim added kind/bug Categorizes issue or PR as related to a bug. good first issue Good for newcomers component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) labels Mar 25, 2022
@irvinlim irvinlim added area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) and removed good first issue Good for newcomers labels Apr 11, 2022
@irvinlim irvinlim mentioned this issue Apr 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(execution): Handle IndependentReconciler bugs in JobQueueController, add tests furiko-io/furiko
1 participant
@irvinlim