Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(execution): Handle IndependentReconciler bugs in JobQueueController, add tests #56

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

irvinlim
Copy link
Member

Fixes #17 and #55.

@irvinlim irvinlim added kind/bug Categorizes issue or PR as related to a bug. component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) labels Apr 16, 2022
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #56 (62a663c) into main (3e131b7) will increase coverage by 2.23%.
The diff coverage is 85.45%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   54.71%   56.94%   +2.23%     
==========================================
  Files         163      164       +1     
  Lines        8133     8174      +41     
==========================================
+ Hits         4450     4655     +205     
+ Misses       3477     3295     -182     
- Partials      206      224      +18     
Impacted Files Coverage Δ
...ution/controllers/jobqueuecontroller/controller.go 27.63% <70.58%> (+27.63%) ⬆️
...g/runtime/controllercontext/mock/context_stores.go 75.00% <75.00%> (ø)
...xecution/controllers/jobqueuecontroller/control.go 48.64% <100.00%> (+48.64%) ⬆️
...llers/jobqueuecontroller/reconciler_independent.go 80.88% <100.00%> (+80.88%) ⬆️
pkg/runtime/controllercontext/mock/context.go 81.25% <100.00%> (+8.83%) ⬆️
...kg/execution/controllers/croncontroller/metrics.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/runtime/reconciler/metrics.go 42.10% <0.00%> (-26.32%) ⬇️
pkg/utils/ktime/time.go 91.89% <0.00%> (+5.40%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e131b7...62a663c. Read the comment docs.

@irvinlim irvinlim merged commit 1a3e2ca into main Apr 16, 2022
@irvinlim irvinlim deleted the irvinlim/fix/job-queue-controller branch April 16, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Jobs created independently of JobConfig ignore startAfter
1 participant