Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CronController tests #30

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Mar 29, 2022

Pending #27 to be merged, since we are using some dependencies from that branch.

This PR adds further tests for CronController, and also refactors some of the scaffold to be more suitable for dependency injection.

@irvinlim irvinlim changed the title feat: Add initial JobController reconciler test feat: Add CronController tests Mar 29, 2022
@irvinlim irvinlim assigned irvinlim and unassigned irvinlim Mar 29, 2022
@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/testing Related to automated testing labels Mar 29, 2022
@irvinlim irvinlim changed the base branch from irvinlim/feat/job-controller-tests to main March 29, 2022 08:06
@irvinlim irvinlim force-pushed the irvinlim/feat/cron-controller-tests branch from 5bfdb13 to b3ec3c5 Compare April 3, 2022 06:39
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #30 (b3ec3c5) into main (31d88de) will increase coverage by 1.79%.
The diff coverage is 64.21%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   47.26%   49.05%   +1.79%     
==========================================
  Files         158      160       +2     
  Lines        7934     7952      +18     
==========================================
+ Hits         3750     3901     +151     
+ Misses       3994     3864     -130     
+ Partials      190      187       -3     
Impacted Files Coverage Δ
cmd/execution-controller/main.go 0.00% <0.00%> (ø)
...lers/jobqueuecontroller/reconciler_perjobconfig.go 0.00% <0.00%> (ø)
pkg/runtime/controllercontext/context_stores.go 16.66% <ø> (ø)
...execution/controllers/croncontroller/controller.go 23.07% <5.00%> (+23.07%) ⬆️
pkg/utils/testutils/uid.go 55.55% <55.55%> (ø)
...kg/execution/controllers/croncontroller/control.go 100.00% <100.00%> (ø)
...execution/controllers/croncontroller/reconciler.go 87.34% <100.00%> (+87.34%) ⬆️
pkg/execution/controllers/croncontroller/util.go 81.81% <100.00%> (+1.17%) ⬆️
pkg/execution/stores/activejobstore/store.go 70.21% <100.00%> (+4.21%) ⬆️
...ersioned/typed/execution/v1alpha1/fake/fake_job.go 73.23% <0.00%> (+8.45%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d88de...b3ec3c5. Read the comment docs.

@irvinlim irvinlim marked this pull request as ready for review April 7, 2022 08:40
@irvinlim irvinlim merged commit 1e901e3 into main Apr 7, 2022
@irvinlim irvinlim deleted the irvinlim/feat/cron-controller-tests branch April 7, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to automated testing component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant