Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Makefile target to deploy snapshot #35

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 8, 2022

Adds a Makefile target to deploy snapshot into K8s cluster using make deploy.

Additional changes:

  1. Moved kustomize edit logic into helper generate-kustomization.sh script, and updated the logic to support generating a brand-new kustomization.yaml which avoids clobbering the main config/default configuration path.
  2. Clean up some accidental changes.
  3. Also push snapshot Docker image tag, which always points to the latest snapshot image tag.

@irvinlim irvinlim added the area/ci Related to CI (Continuous Integration) label Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #35 (7244f1e) into main (5f120c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   49.74%   49.74%           
=======================================
  Files         159      159           
  Lines        7988     7988           
=======================================
  Hits         3974     3974           
  Misses       3831     3831           
  Partials      183      183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f120c8...7244f1e. Read the comment docs.

@irvinlim irvinlim merged commit 96bb8ca into main Apr 8, 2022
@irvinlim irvinlim deleted the irvinlim/chore/deploy-snapshot branch April 8, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to CI (Continuous Integration)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant