Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Support maxEnqueuedJobs #43

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

irvinlim
Copy link
Member

Closes #15.

Adds a new config field maxEnqueuedJobs, which defines the global maximum of enqueued jobs that can be created per JobConfig.

@irvinlim irvinlim force-pushed the irvinlim/feat/max-enqueued-jobs branch from ddfff3f to c13136b Compare April 11, 2022 16:16
@irvinlim irvinlim force-pushed the irvinlim/feat/max-enqueued-jobs branch from c13136b to b397309 Compare April 11, 2022 16:22
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #43 (b397309) into main (5245548) will decrease coverage by 0.44%.
The diff coverage is 29.35%.

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   51.89%   51.45%   -0.45%     
==========================================
  Files         162      163       +1     
  Lines        8024     8095      +71     
==========================================
+ Hits         4164     4165       +1     
- Misses       3664     3731      +67     
- Partials      196      199       +3     
Impacted Files Coverage Δ
apis/config/v1alpha1/dynamicconfig_types.go 100.00% <ø> (ø)
apis/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...execution/controllers/croncontroller/controller.go 25.00% <0.00%> (+1.31%) ⬆️
...g/execution/controllers/croncontroller/recorder.go 0.00% <0.00%> (ø)
pkg/execution/mutation/mutation.go 84.37% <0.00%> (-0.45%) ⬇️
pkg/runtime/controllercontext/context_configs.go 18.64% <33.33%> (+2.64%) ⬆️
pkg/execution/validation/validation.go 91.95% <73.68%> (-1.47%) ⬇️
...execution/controllers/croncontroller/reconciler.go 81.70% <76.92%> (-5.64%) ⬇️
...kg/execution/controllers/croncontroller/control.go 100.00% <100.00%> (ø)
pkg/runtime/configloader/defaults_loader.go 63.15% <100.00%> (+0.99%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5245548...b397309. Read the comment docs.

@irvinlim irvinlim merged commit 650aab1 into main Apr 11, 2022
@irvinlim irvinlim deleted the irvinlim/feat/max-enqueued-jobs branch April 11, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support specifying max Enqueue length
1 participant