Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Change maxRetryAttempts to maxAttempts #48

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

irvinlim
Copy link
Member

Closes #45.

  • Updates all references of maxRetryAttempts to maxAttempts.
  • All logic interfacing with field are updated to count the first task as the first attempt.

@irvinlim irvinlim force-pushed the irvinlim/feat/max-attempts branch from 075abfb to 6e0e6c7 Compare April 15, 2022 20:47
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #48 (acdf89c) into main (e24be62) will increase coverage by 0.22%.
The diff coverage is 92.45%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   54.47%   54.69%   +0.22%     
==========================================
  Files         163      163              
  Lines        8097     8128      +31     
==========================================
+ Hits         4411     4446      +35     
+ Misses       3478     3474       -4     
  Partials      208      208              
Impacted Files Coverage Δ
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
.../execution/controllers/jobcontroller/reconciler.go 75.15% <ø> (ø)
pkg/execution/validation/corev1.go 77.77% <0.00%> (ø)
pkg/execution/variablecontext/provider.go 51.51% <0.00%> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 56.61% <100.00%> (ø)
pkg/core/validation/generic.go 100.00% <100.00%> (ø)
pkg/execution/mutation/mutation.go 84.61% <100.00%> (+0.24%) ⬆️
pkg/execution/validation/validation.go 92.01% <100.00%> (+0.06%) ⬆️
pkg/utils/execution/job/task_utils.go 94.23% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24be62...acdf89c. Read the comment docs.

@irvinlim irvinlim force-pushed the irvinlim/feat/max-attempts branch from 6e0e6c7 to acdf89c Compare April 15, 2022 20:51
@irvinlim irvinlim merged commit 84123e0 into main Apr 15, 2022
@irvinlim irvinlim deleted the irvinlim/feat/max-attempts branch April 15, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change MaxRetryAttempts to MaxAttempts
1 participant