Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): Use standard reconciler test framework #57

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 17, 2022

Extract out a common ReconcilerTest for setting up and executing reconciler tests.

@irvinlim irvinlim added area/testing Related to automated testing kind/refactor Issues identifying refactors needed or PRs to perform refactors labels Apr 17, 2022
@irvinlim irvinlim assigned irvinlim and unassigned irvinlim Apr 17, 2022
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #57 (1c8f331) into main (1a3e2ca) will increase coverage by 0.45%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   56.94%   57.40%   +0.45%     
==========================================
  Files         164      165       +1     
  Lines        8174     8318     +144     
==========================================
+ Hits         4655     4775     +120     
- Misses       3295     3311      +16     
- Partials      224      232       +8     
Impacted Files Coverage Δ
pkg/runtime/testing/action.go 83.33% <60.00%> (-16.67%) ⬇️
.../execution/controllers/jobcontroller/controller.go 33.80% <75.00%> (+1.91%) ⬆️
...ution/controllers/jobqueuecontroller/controller.go 29.48% <75.00%> (+1.85%) ⬆️
pkg/runtime/testing/reconciler.go 77.50% <77.50%> (ø)
pkg/runtime/reconciler/metrics.go 68.42% <0.00%> (+26.31%) ⬆️
...kg/execution/controllers/croncontroller/metrics.go 100.00% <0.00%> (+85.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3e2ca...1c8f331. Read the comment docs.

@irvinlim irvinlim merged commit c828eea into main Apr 17, 2022
@irvinlim irvinlim deleted the irvinlim/chore/reconciler-test-framework branch April 17, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to automated testing kind/refactor Issues identifying refactors needed or PRs to perform refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant