Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add kill subcommand #84

Merged
merged 3 commits into from
May 29, 2022
Merged

feat(cli): Add kill subcommand #84

merged 3 commits into from
May 29, 2022

Conversation

irvinlim
Copy link
Member

Closes #82.

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. area/furiko-cli Related to the command-line interface (CLI) utility. labels May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #84 (e245a0f) into main (8320441) will increase coverage by 0.07%.
The diff coverage is 73.26%.

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   62.79%   62.87%   +0.07%     
==========================================
  Files         199      200       +1     
  Lines       10340    10434      +94     
==========================================
+ Hits         6493     6560      +67     
- Misses       3499     3517      +18     
- Partials      348      357       +9     
Impacted Files Coverage Δ
pkg/cli/formatter/time.go 82.35% <50.00%> (-17.65%) ⬇️
pkg/cli/cmd/cmd_kill.go 69.23% <69.23%> (ø)
pkg/cli/cmd/cmd.go 92.30% <100.00%> (+0.20%) ⬆️
pkg/cli/cmd/cmd_get_job.go 79.19% <100.00%> (ø)
pkg/cli/cmd/cmd_get_jobconfig.go 72.95% <100.00%> (ø)
pkg/cli/cmd/cmd_list_job.go 82.10% <100.00%> (ø)
pkg/cli/cmd/cmd_list_jobconfig.go 86.04% <100.00%> (ø)
pkg/cli/cmd/cmd_run.go 76.47% <100.00%> (ø)
pkg/runtime/testing/command.go 77.50% <100.00%> (+2.15%) ⬆️
pkg/runtime/testing/reconciler.go 74.41% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8320441...e245a0f. Read the comment docs.

@irvinlim irvinlim merged commit 9e17087 into main May 29, 2022
@irvinlim irvinlim deleted the irvinlim/feat/kill-job-cli branch May 29, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/furiko-cli Related to the command-line interface (CLI) utility. component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support kill job in CLI
1 participant