Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Avoid using activeDeadlineSeconds to kill tasks #85

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Jun 3, 2022

Closes #64. Also helps #63.

Avoids using activeDeadlineSeconds to kill tasks, instead it will use API deletion instead, which supports graceful termination.

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/workloads Related to workload execution (e.g. jobs, tasks) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features. labels Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #85 (d37f97c) into main (9e17087) will decrease coverage by 0.14%.
The diff coverage is 86.04%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   62.87%   62.72%   -0.15%     
==========================================
  Files         200      200              
  Lines       10434    10287     -147     
==========================================
- Hits         6560     6453     -107     
+ Misses       3517     3486      -31     
+ Partials      357      348       -9     
Impacted Files Coverage Δ
apis/config/v1alpha1/dynamicconfig_types.go 100.00% <ø> (ø)
apis/config/v1alpha1/zz_generated.deepcopy.go 10.45% <0.00%> (+0.16%) ⬆️
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
...g/execution/taskexecutor/podtaskexecutor/labels.go 100.00% <ø> (ø)
.../execution/controllers/jobcontroller/reconciler.go 71.09% <83.05%> (+0.16%) ⬆️
...execution/taskexecutor/podtaskexecutor/pod_task.go 90.64% <100.00%> (+4.52%) ⬆️
pkg/execution/util/job/condition.go 95.52% <100.00%> (+0.28%) ⬆️
pkg/execution/util/job/phase.go 93.75% <100.00%> (ø)
pkg/execution/util/job/timeout.go 100.00% <100.00%> (ø)
pkg/utils/ktime/time.go 92.30% <100.00%> (+0.41%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e17087...d37f97c. Read the comment docs.

@irvinlim irvinlim force-pushed the irvinlim/feat/delete-tasks branch from 53774f9 to d37f97c Compare June 3, 2022 18:06
@irvinlim irvinlim merged commit c6c08dd into main Jun 3, 2022
@irvinlim irvinlim deleted the irvinlim/feat/delete-tasks branch June 3, 2022 18:19
@irvinlim irvinlim linked an issue Jun 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workloads Related to workload execution (e.g. jobs, tasks) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Using active deadline does not wait for container to terminate before finishing
1 participant