Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add enable/disable subcommands #89

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Jun 3, 2022

Adds two new subcommands:

Usage:
  furiko [command]

Available Commands:
  ...
  disable     Disable automatic scheduling for a JobConfig.
  enable      Enable automatic scheduling for a JobConfig.
  ...

Detailed subcommand help:

Disables automatic scheduling for a JobConfig.

If the specified JobConfig does not have a schedule, then an error will be thrown.
If the specified JobConfig is already disabled, then this is a no-op.

Usage:
  furiko disable [flags]

Examples:
  # Disable scheduling for the JobConfig.
  furiko disable send-weekly-report
Enables automatic scheduling for a JobConfig.

If the specified JobConfig does not have a schedule, then an error will be thrown.
If the specified JobConfig is already enabled, then this is a no-op.

Usage:
  furiko enable [flags]

Examples:
  # Enable scheduling for the JobConfig.
  furiko enable send-weekly-report

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features. area/furiko-cli Related to the command-line interface (CLI) utility. labels Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #89 (867c7f4) into main (25d2757) will increase coverage by 0.26%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   62.87%   63.13%   +0.26%     
==========================================
  Files         200      202       +2     
  Lines       10334    10456     +122     
==========================================
+ Hits         6497     6601     +104     
- Misses       3489     3498       +9     
- Partials      348      357       +9     
Impacted Files Coverage Δ
pkg/cli/cmd/cmd_disable.go 73.21% <73.21%> (ø)
pkg/cli/cmd/cmd_enable.go 73.21% <73.21%> (ø)
pkg/cli/cmd/cmd.go 92.68% <100.00%> (+0.37%) ⬆️
pkg/runtime/testing/action.go 75.86% <0.00%> (+3.44%) ⬆️
pkg/execution/mutation/mutation.go 89.09% <0.00%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d2757...867c7f4. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@irvinlim irvinlim force-pushed the irvinlim/feat/enable-disable-cli branch from d2aff72 to 867c7f4 Compare June 3, 2022 20:57
@irvinlim irvinlim merged commit 0954bd6 into main Jun 4, 2022
@irvinlim irvinlim deleted the irvinlim/feat/enable-disable-cli branch June 4, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/furiko-cli Related to the command-line interface (CLI) utility. component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant