Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YOLOv5 postprocess #18

Merged
merged 24 commits into from
Jan 25, 2024
Merged

Conversation

furiosamg
Copy link
Contributor

@furiosamg furiosamg commented Dec 6, 2023

Changes

  • Switched to Ziglang for building manylinux wheels
  • Renamed YOLOv5 to YOLO for version-agnostic postprocessing
  • Updated Rust toolchain version
  • Added and used add_submodule utility function
  • Enhanced YOLO postprocess:
    • Defaults to class-aware NMS (can be turned off with agnostic=True)
    • Populates boxes when interpretable into multiple classes (multi-label NMS)
    • Update codes to avoid boundary checks
    • Returns List[ndarray[shape=(num_dets, 6)] instead of ODResult class list
    • Now stores agnostic parameter within postprocessor class
    • => Better accuracy ☺️

@furiosamg furiosamg changed the title Update import granularity Update YOLOv5 postprocess Dec 9, 2023
@furiosamg furiosamg marked this pull request as ready for review December 11, 2023 08:02
src/yolo/mod.rs Outdated Show resolved Hide resolved
src/yolo/utils.rs Outdated Show resolved Hide resolved
src/yolo/mod.rs Outdated Show resolved Hide resolved
src/yolo/mod.rs Outdated Show resolved Hide resolved
src/yolo/mod.rs Outdated Show resolved Hide resolved
@furiosamg furiosamg self-assigned this Dec 18, 2023
Copy link

@donghun-furiosa donghun-furiosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@furiosamg
Copy link
Contributor Author

@hyunsik 님, 1차 리뷰가 끝나서 머지를 위한 리뷰 부탁드리겠습니다.

Copy link
Member

@hyunsik hyunsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 메시지를 놓쳐서 리뷰가 너무 늦었네요. 죄송합니다. 고생 많으셨습니다. 더 잘 정돈된 것 같습니다. 머지하셔도 좋을 것 같습니다.

@furiosamg furiosamg merged commit 91346da into furiosa-ai:main Jan 25, 2024
@furiosamg furiosamg mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants